Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20141115 RC #702

Open
wants to merge 35 commits into
base: release
Choose a base branch
from
Open

20141115 RC #702

wants to merge 35 commits into from

Conversation

giuliano176
Copy link
Contributor

No description provided.

giuliano176 and others added 30 commits August 28, 2024 12:33
…-editor installed (#652)


---------

Co-authored-by: Mauro Bartolomeoli <[email protected]>
…omposing-for-specific-mail

fix: slow response in email composer for long email
* refactor: organize code into smaller files

* refactor: remove iframe in message renderer

* WIP: convert get-quoted-text-util to .ts

* WIP: fixed most of type errors in get-quoted-text-util.ts

- there is ONE check that fails because code tries to assign undefined values to a record and that is just not possible

* WIP: get-quoted-text-util.ts use "as" as last resort

- decided to put "as" without changing code behavior.

* chore: add characterization tests for quoted text utils

- they can help future developers in refactor

* chore: more characterization tests for quoted text utils

- testes htmlencode

* chore(quoted text utils): group exported functions all along at the end of file

* WIP: extract function from getQuotedTextOnly to avoid multiple
expensive dom parsing in case of big emails

- applied only on html renderer for now

- it's not clear the role of this function and why we might need a quoted text and so on. This is just a test to see if performance improves

* refactor: create two functions to handle original email content

- avoid declaring a function with a boolean "isHtml" and equivalaent getQuotedTextOnly with same boolean and pass the same value a gazillion times.

- html-renderer changes from: getOriginalContent(content, isHtml: true), getQuotedtext(content, isHtml: true) to getOriginalHtmlContent(content), getQuotedTextFromContent(originalContent, content).
- similar thing for text-render, expect isHtml was false.

* refactor: getOriginalHtmlContent

* feat: trim body content of email to 150k characters

* feat: add max property to search-conv

* test: update search-conv.test.ts to reflect default max of 250k

* chore: add data-testid to html renderer and update test

* refactor: use search-conv.ts api in search-conv redux thunk

* refactor: add truncated field to SoapMailMessagePart (optional) and MailMessagePart (required)

* test: add tests on truncated for mail part normalization

* feat: normalize truncated property in body part

* Revert "refactor: add truncated field to SoapMailMessagePart (optional) and MailMessagePart (required)"

This reverts commit 6dba4b3.

* test: add test for normalize message body

* feat: add truncated message warning banner

* test: add tests for html renderer truncated body banner

* WIP: I don't know what's going on

* test: html message renderer updates search store on load message

* feat: add getMsg api call for mails preview panel

* refactor: move store/hooks logic in html-renderer

- html-renderer is the only component that needs participants, parts, etc.
- remove unused props from mail-preview.tsx and mail-preview-content.tsx

* feat: add max optional property to getMsgSoapApi

* feat: expose retrieveFullMessage hook

* test: add tests on message too large when in mails module

* feat: add async thunk to get full message
- refactor getMsg thunk name
- add max equal to 250k to getMsgAsyncThunk

* refactor: html-message-renderer.tsx use message from search module when in search module

- add test for it

* chore: update commons

* test(use-request-debounced-message): add test

* test: add simple characterization tests for get-quoted-text-utils

- trying to understand how this code behaves

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

- add gmail_quote case

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

* test: add more characterization tests for get-quoted-text-utils

add cases for quoted blocks

* fix: chose the right message in conversation message preview

* feat: add animated loader to load message button

* refactor: re-extract MailContent into MailPreviewContent

- remove unused props

* refactor: rename search preview to extra-window

* refactor: remove shimmer logo from search components

* chore: add translation to LOADING... when message loading

* refactor: extract message truncated/too large banner

* refactor: extract also banner-view-external-images.tsx from html-renderer

---------

Co-authored-by: Giuliano Caregnato <[email protected]>
…-in-email-composing-for-specific-mail

Revert "fix: slow response in email composer for long email"

---------

Co-authored-by: Keshav Bhatt <[email protected]>
Co-authored-by: Giuliano Caregnato <[email protected]>
* feat: show smime option if email is smime signed

* chore: certificate detail added in modal

* chore: update the ui for smime and show error messages

* chore: did ui changes and tests added

* chore: tests added for smime related

* chore: changes done as per the response and fix test

---------

Co-authored-by: Manan Patel <[email protected]>
…er that already exists a generic error is raised (#690)

* feat: added check for existing folder name, with specific error on share folder invitation acceptance

* feat: added tests for mount-share-calendar

* feat: added tests for share-calendar-actions

* chore: refactored and completed tests
* refactor: switched to json format for CreateMountpoint request in accept shared folder; also added some types

* refactor: changed references to calendar into folder
@giuliano176 giuliano176 requested a review from a team as a code owner November 15, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.